Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception message #634

Merged
merged 2 commits into from
Dec 5, 2018
Merged

Conversation

lordofinsomnia
Copy link
Contributor

I have noticed that when an error occurs that user does not receive user friendly message. Before my change user has received an json response in args as string.

error.exception.args[0] has value of

'{
  "error": {
    "code": 404,
    "message": "Requested entity was not found.",
    "status": "NOT_FOUND"
  }
}
'

after my change args has populated with dict with values from json.

self.assertEqual(error.exception.args[0]['code'], 404)
self.assertEqual(error.exception.args[0]['message'], 'Requested entity was not found.')
self.assertEqual(error.exception.args[0]['status'], 'NOT_FOUND')

Thanks for great lib. 👍

@lordofinsomnia
Copy link
Contributor Author

lordofinsomnia commented Dec 4, 2018

This build failure is strange.
on my side it all works perfect.

GS_RECORD_MODE=all GS_CREDS_FILENAME=credentials.json nosetests -vv tests/test.py
nose.config: INFO: Ignoring files matching ['^\\.', '^_', '^setup\\.py$']
test_numeric_value (tests.test.CellTest) ... ok
test_properties (tests.test.CellTest) ... ok
test_access_non_existing_spreadsheet (tests.test.ClientTest) ... ok
test_copy (tests.test.ClientTest) ... ok
test_create (tests.test.ClientTest) ... ok
test_import_csv (tests.test.ClientTest) ... ok
test_no_found_exeption (tests.test.ClientTest) ... ok
test_openall (tests.test.ClientTest) ... ok
test_add_del_worksheet (tests.test.SpreadsheetTest) ... ok
test_get_worksheet (tests.test.SpreadsheetTest) ... ok
test_properties (tests.test.SpreadsheetTest) ... ok
test_sheet1 (tests.test.SpreadsheetTest) ... ok
test_values_get (tests.test.SpreadsheetTest) ... ok
test_worksheet (tests.test.SpreadsheetTest) ... ok
test_worksheet_iteration (tests.test.SpreadsheetTest) ... ok
test_a1_to_rowcol (tests.test.UtilsTest) ... ok
test_addr_converters (tests.test.UtilsTest) ... ok
test_extract_id_from_url (tests.test.UtilsTest) ... ok
test_get_gid (tests.test.UtilsTest) ... ok
test_no_extract_id_from_url (tests.test.UtilsTest) ... ok
test_numericise (tests.test.UtilsTest) ... ok
test_rowcol_to_a1 (tests.test.UtilsTest) ... ok
test_acell (tests.test.WorksheetTest) ... ok
test_append_row (tests.test.WorksheetTest) ... ok
test_cell (tests.test.WorksheetTest) ... ok
test_clear (tests.test.WorksheetTest) ... ok
test_delete_row (tests.test.WorksheetTest) ... ok
test_find (tests.test.WorksheetTest) ... ok
test_findall (tests.test.WorksheetTest) ... ok
test_get_all_records (tests.test.WorksheetTest) ... ok
test_get_all_records_different_header (tests.test.WorksheetTest) ... ok
test_get_all_values (tests.test.WorksheetTest) ... ok
test_insert_row (tests.test.WorksheetTest) ... ok
test_range (tests.test.WorksheetTest) ... ok
test_resize (tests.test.WorksheetTest) ... ok
test_update_acell (tests.test.WorksheetTest) ... ok
test_update_cell (tests.test.WorksheetTest) ... ok
test_update_cell_multiline (tests.test.WorksheetTest) ... ok
test_update_cell_unicode (tests.test.WorksheetTest) ... ok
test_update_cells (tests.test.WorksheetTest) ... ok
test_update_cells_noncontiguous (tests.test.WorksheetTest) ... ok
test_update_cells_unicode (tests.test.WorksheetTest) ... ok

----------------------------------------------------------------------
Ran 42 tests in 97.856s

OK

@burnash
Copy link
Owner

burnash commented Dec 5, 2018

Thanks for the PR. Please ignore Travis failure, it uses recorded data and there's an unrelated issue with it.

@burnash burnash merged commit d5a20cf into burnash:master Dec 5, 2018
@burnash
Copy link
Owner

burnash commented Dec 5, 2018

🎉

@lordofinsomnia
Copy link
Contributor Author

wuhu. :)
tnx.

@lordofinsomnia lordofinsomnia deleted the exceptionMessage branch December 5, 2018 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants