CI: test that we support 32 bits #426
Comments
mvdan
added a commit
to mvdan/garble-fork
that referenced
this issue
Jan 6, 2022
Note that this cross-compilation disables cgo by default, and so the cgo.txt test script isn't run on GOARCH=386. That seems fine for now, as the test isn't arch-specific. This testing uncovered one build failure in internal/literals; the comparison between int and math.MaxUint32 is invalid on 32-bit. To fix that build failure, use int64 consistently. One test also incorrectly assumed amd64; it now supports 386 too. For any other architecture, it's being skipped for now. Finally, use "go env" rather than "go version" on CI, which gives us much more useful information, and also includes Go's own version now via GOVERSION. Fixes burrowers#426.
Merged
mvdan
added a commit
to mvdan/garble-fork
that referenced
this issue
Jan 6, 2022
Note that this cross-compilation disables cgo by default, and so the cgo.txt test script isn't run on GOARCH=386. That seems fine for now, as the test isn't arch-specific. This testing uncovered one build failure in internal/literals; the comparison between int and math.MaxUint32 is invalid on 32-bit. To fix that build failure, use int64 consistently. One test also incorrectly assumed amd64; it now supports 386 too. For any other architecture, it's being skipped for now. I also had to increase the -race test timeout, as it usually takes 8-9m on GitHub Actions, and the timeout would sometimes trigger. Finally, use "go env" rather than "go version" on CI, which gives us much more useful information, and also includes Go's own version now via GOVERSION. Fixes burrowers#426.
lu4p
pushed a commit
that referenced
this issue
Jan 6, 2022
Note that this cross-compilation disables cgo by default, and so the cgo.txt test script isn't run on GOARCH=386. That seems fine for now, as the test isn't arch-specific. This testing uncovered one build failure in internal/literals; the comparison between int and math.MaxUint32 is invalid on 32-bit. To fix that build failure, use int64 consistently. One test also incorrectly assumed amd64; it now supports 386 too. For any other architecture, it's being skipped for now. I also had to increase the -race test timeout, as it usually takes 8-9m on GitHub Actions, and the timeout would sometimes trigger. Finally, use "go env" rather than "go version" on CI, which gives us much more useful information, and also includes Go's own version now via GOVERSION. Fixes #426.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See #355 (comment).
We should test a 32-bit GOARCH as a target platform, as well as a host platform. For instance, amd64 building for 386, and 386 building for amd64.
We should be able to write the test as part of crossbuild.txt, and then add a 32-bit test run on the CI matrix.
The text was updated successfully, but these errors were encountered: