Move specific methods from BaseRuntime to JcfRuntime #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iconara PTAL |
iconara
approved these changes
Jun 7, 2019
jmespath-core/src/main/java/io/burt/jmespath/jcf/JcfRuntime.java
Outdated
Show resolved
Hide resolved
Motivation: ~200 loc in JcfRuntime are actually are not used by Jackson and Gson runtimes but are specific to JcfRuntime. Those protected methods needlessly increase the API surface, make code analysis more complicated and make things more confusing for users who might want to implement a Runtime. Modification: Move unparse methods to JcfRuntime and make them private. Result: Smaller BaseRuntime API surface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
~200 loc in JcfRuntime are actually are not used by Jackson and Gson runtimes but are specific to JcfRuntime.
Those protected methods needlessly increase the API surface, make code analysis more complicated and make things more confusing for users who might want to implement a Runtime.
Modification:
Move unparse methods to JcfRuntime and make them private.
Result:
Smaller BaseRuntime API surface.