Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move specific methods from BaseRuntime to JcfRuntime #47

Merged
merged 1 commit into from
Jun 7, 2019
Merged

Move specific methods from BaseRuntime to JcfRuntime #47

merged 1 commit into from
Jun 7, 2019

Commits on Jun 7, 2019

  1. Move specific methods from BaseRuntime to JcfRuntime 

    Motivation:

~200 loc in JcfRuntime are actually are not used by Jackson and Gson runtimes but are specific to JcfRuntime.

Those protected methods needlessly increase the API surface, make code analysis more complicated and make things more confusing for users who might want to implement a Runtime.

Modification:

Move unparse methods to JcfRuntime and make them private.

Result:

Smaller BaseRuntime API surface.
    @slandelle
    slandelle committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    467c7af View commit details
    Browse the repository at this point in the history