Treat unreadable service files as invalid #189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaneti
changed the title
yaneti
force-pushed
the
patch-1
branch
3 times, most recently
from
e999440
to
0f91a09
Compare
dvdhrm
requested changes
Jan 22, 2019
There was a problem hiding this comment.
Thanks a lot! The second hunk in your patch can be dropped. Can you respin the patch, or should I do that when I apply it?
Also, we use sign-offs, so please use git commit -s or provide your sign-off separately. For background information, see: https://developercertificate.org/
|
Please feel free not to merge the fix and deal with all the cases as you see fit. |
This is a followup to a0869bd. If we return 0 the parsing is considered complete and bad things happen in manager_load_service_file. Signed-off-by: Yanko Kaneti <yaneti@declera.com>
|
I've mangled this simple patch enough I think. :) added a sign-off . If its still not up to par please apply whatever you deem necessary to avoid the crashing :) |
dvdhrm
approved these changes
Jan 22, 2019
|
This is now merged. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to a0869bd.
If we return 0 the parsing is considered complete and bad thing happen in manager_load_service_file