memfd: provide proper abstractions #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add proper helpers around memfds. This includes a new memfd-constructor that follows newest kernel standards around EXEC/NOEXEC handling. Furthermore, add GET_SEALS and ADD_SEALS wrappers to avoid open-coding them all over the place. This does not make use of the new helpers, yet, but only adds tests to verify their behavior. Reported-by: Дамјан Георгиевски Signed-off-by: David Rheinsberg <david@readahead.eu>
Rather than open-coding the memfd syscalls, make use of the new misc_memfd() helpers. Signed-off-by: David Rheinsberg <david@readahead.eu>
|
(updated to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide proper abstractions for memfd operations. This is especially necessary with the new
MFD_EXECandMFD_NOEXEC_SEALfeatures of the kernel, which requires all memfd users to update the code to use one of the new flags.Unfortunately, they decided against providing
MFD_NOEXEC, but instead just provideMFD_NOEXEC_SEAL, which is a combination ofMFD_ALLOW_SEALING,MFD_NOEXEC, andF_SEAL_EXEC. This is really awkward to use in helpers, but I think I got something that works well enough.Reported in #322.