Fix types for ember v5.6 #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested my app with these changes and this also fixes #784 |
HeroicEric
reviewed
Jan 24, 2024
| import type { Behavior } from '../-behavior'; | ||
| import type { LinkParams } from '../-params'; | ||
| import type RouteInfo from '@ember/routing/route-info'; | ||
| import type RouterService from '@ember/routing/router-service'; | ||
| import type Transition from '@ember/routing/transition'; | ||
| import Owner from '@ember/owner'; |
There was a problem hiding this comment.
when I was testing this branch locally I noticed that the changes here were causing some linting errors
| [js] /--------/buschtoens/ember-link/ember-link/src/services/link-manager.ts
│ [js] 1:1 error Run autofix to sort these imports! simple-import-sort/imports
│ [js] 17:1 error All imports in the declaration are only used as types. Use `import type` @typescript-eslint/consistent-type-imports
│ [js]
│ [js] ✖ 2 problems (2 errors, 0 warnings)
│ [js] 2 errors and 0 warnings potentially fixable with the `--fix` option.
|
Yeah, I fell asleep while working on this 💤 Gonna continue soon-ish to have it done by the weekend =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.