Tuning Dimension Smoothers First Version #12
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mdancho84
In this PR I have added the arguments that we discussed in Slack (up to 5) to be able to tune the dimensions of the smoothers. As you can see in this example, each term has the dimension passed as an argument (in order). I have also created the parameters in the file "dials-gen_additive_mod_params.R" to be able to tune.
I haven't had time to test yet but everything should work for tuning (I think). So you can play around a bit and see what you think.