Skip to content
This repository has been archived by the owner on Sep 7, 2018. It is now read-only.

IE8 compatibility: use replacement for Array.some(..) #121

Closed
meisl opened this issue Mar 5, 2012 · 5 comments
Closed

IE8 compatibility: use replacement for Array.some(..) #121

meisl opened this issue Mar 5, 2012 · 5 comments
Milestone

Comments

@meisl
Copy link
Member

meisl commented Mar 5, 2012

Setup:

  • WinXP Pro SP3 32bit, node 0.6.11 via .msi installer, npm is 1.1.1 (came with the .msi)
  • buster 0.4.5 installed via npm with a few hacks by hand to get it going:
  • alongside buster/: pre-built contextify (ATTENTION: needs some more, not to be used as-is)
  • watch-tree installed via npm into buster/node_modules (used by buster-autotest, missing from deps) - yet this is defunct on Win
    -simple browser tests (html-scaffold only) use the 0.4.5 buster-test.js and buster-test.css from busterjs.org

Problem:
IE8 doesn't support Array.some(..) which is used in buster-test.js line 3408 (simple browser test)

Workaround:
My workaround at the moment is to set Array.prototype.some to my own if it's undefined.
However, I'm pretty sure you guys already have a replacement in place somewhere, just not always using it.

Note:
this one's pretty similar to #120 re Object.create(..), just the function and the line nr are different.

p.s.: I'm fully aware that Windows support is a thing for the future - just trying to help a little with it.

@cjohansen
Copy link
Member

Thanks! Help with Windows support is greatly appreciated. Keep 'em coming!

@cjohansen
Copy link
Member

@meisl
Copy link
Member Author

meisl commented Mar 8, 2012

Pretty quick you are, this I must say. Thanks :)
To help with actual patches i hope, in the future.

@cjohansen
Copy link
Member

It's a pleasure closing such an awesome detailed bug report :) thanks again, and keep 'em coming!

@meisl
Copy link
Member Author

meisl commented Mar 9, 2012

Welcome you are and mine the pleasure is. And, y'know, coming I'll keep 'em; sure of this you can be :)

@meisl meisl mentioned this issue May 4, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants