Merge pull request #620 from kevinansfield/blank-post-on-paste-guard

Fix error when pasting HTML that parses to a blank doc
bustle · Jun 20, 2018 · 3b110e6 · 3b110e6
2 parents bbd676b + cd7fa1d
commit 3b110e6
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/src/js/editor/post/post-inserter.js b/src/js/editor/post/post-inserter.js
@@ -278,7 +278,9 @@ export default class Inserter {
 
   insert(cursorPosition, newPost) {
     let visitor = new Visitor(this, cursorPosition);
-    visitor.visit(newPost);
+    if (!newPost.isBlank) {
+      visitor.visit(newPost);
+    }
     return visitor.cursorPosition;
   }
 }
diff --git a/tests/acceptance/editor-copy-paste-test.js b/tests/acceptance/editor-copy-paste-test.js
@@ -412,3 +412,25 @@ test('paste with shift key pastes plain text', (assert) => {
 
   assert.postIsSimilar(editor.post, expected);
 });
+
+test('paste with html that parses to blank doc doesn\'t error', (assert) => {
+  let expected;
+  let mobiledoc = Helpers.mobiledoc.build(({post, markupSection, marker}) => {
+    expected = post([
+      markupSection('p', [])
+    ]);
+
+    return post([
+      markupSection('p', [marker('abcd')])
+    ]);
+  });
+
+  editor = new Editor({mobiledoc, cards});
+  editor.render(editorElement);
+
+  Helpers.dom.setCopyData('text/html', `<div></div>`);
+  editor.selectRange(editor.post.toRange());
+  Helpers.dom.triggerPasteEvent(editor);
+
+  assert.postIsSimilar(editor.post, expected);
+});