Fix error when pasting HTML that parses to a blank doc #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have had this issue pop up a couple times in our app at Yapp and I believe this PR would improve the current experience. The second question does concern me a bit, but I'm not sure what would be better behavior. Having the editor do nothing in that case would not be a better experience in my opinion. |
kevinansfield
added a commit
to TryGhost/Admin
that referenced
this pull request
Jun 18, 2018
…raphs refs TryGhost/Ghost#9623 - switch to custom `mobiledoc-kit` build - fixes top-level elements not being run through parser plugins (bustle/mobiledoc-kit#627) - fixes <kbd>Alt</kbd> getting stuck and causing <kbd>Backspace</kbd> to delete whole words (bustle/mobiledoc-kit#626) - fixes error that can occur when a paste results in blank insert (bustle/mobiledoc-kit#620) - add new `figureToImageCard` parser - replaces hacky workaround to detect an image+figcaption inside the `imgToCard` parser plugin - remove wrapping of html in a `<div>...</div>` when pasting - no longer necessary now that top-level elements are parsed - fixes rich-text pastes where multiple paragraphs would be collapsed into a single paragraph
mixonic
suggested changes
Jun 18, 2018
src/js/editor/event-manager.js
Outdated
| }); | ||
| if (!pastedPost.isBlank) { | ||
| editor.run(postEditor => { | ||
| let nextPosition = postEditor.insertPost(position, pastedPost); |
There was a problem hiding this comment.
@kevinansfield I think we should have insertPost be able to insert a blank post. That seems valid.
closes bustle#619 - it's possible to paste HTML that parses into a blank doc, if the paste results in a section being replaced then the `post-inserter` would throw an error because it expects the new post to have sections - adds a guard in the paste event to avoid inserting a blank post
kevinansfield
force-pushed
the
blank-post-on-paste-guard
branch
from
ba81444
to
cd7fa1d
Compare
mixonic
approved these changes
Jun 20, 2018
|
Awesome, thanks @kevinansfield! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #619
post-inserterwould throw an error because it expects the new post to have sectionsQUESTIONS:
post-inserter.js?