Test that cursorDidChange callback not fired after editor is destroyed

refs #319

src/js/editor/editor.js

@@ -188,22 +188,6 @@ class Editor {
     this.runCallbacks(CALLBACK_QUEUES.DID_RENDER);
   }
 
-  addCallback(...args) {
-    this._callbacks.addCallback(...args);
-  }
-
-  addCallbackOnce(...args) {
-    this._callbacks.addCallbackOnce(...args);
-  }
-
-  runCallbacks(...args) {
-    if (this._isDestroyed) {
-      // warn -- should not run after destroyed
-      return;
-    }
-    this._callbacks.runCallbacks(...args);
-  }
-
   /**
    * @param {Element} element The DOM element to render into.
    *        Its contents will be replaced by the editor's rendered post.
@@ -911,7 +895,7 @@ class Editor {
 
   runCallbacks(...args) {
     if (this._isDestroyed) {
-      // warn -- should not run after destroyed
+      // TODO warn that callback attempted after editor was destroyed
       return;
     }
     this._callbacks.runCallbacks(...args);

tests/unit/editor/editor-events-test.js

@@ -109,3 +109,22 @@ test('cursorDidChange callback fired after keypress', (assert) => {
     done();
   });
 });
+
+test('cursorDidChange callback not fired if editor is destroyed', (assert) => {
+  assert.expect(1);
+  let done = assert.async();
+
+  let cursorChanged = 0;
+  editor.cursorDidChange(() => cursorChanged++);
+
+  Helpers.dom.clearSelection();
+  Helpers.dom.triggerEvent(document, 'mouseup');
+  editor.destroy();
+  editor = null;
+
+  setTimeout(() => {
+    assert.equal(cursorChanged, 0, 'callback not fired');
+
+    done();
+  });
+});