Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#98 tried to avoid making apps ever have to explicitly start requests by using a too-clever hack involving
isUniquelyReferenced
. This was a bad idea: it was confusing, and precluded several kinds of request decoration one might want to do.This PR adds a
start()
method to theRequest
protocol. Under most circumstances, apps will not have to call it. Siesta will still automatically start requests in two situations:Resource.request(…)
(and thusload()
andloadIfNeeded()
as well) will start whatever request comes out of the configured decorators.RequestChainAction.PassTo
starts the returned request.Manual start is useful in two cases:
Request.repeated()
no longer returns an already-started request. This allows for delayed retries.