New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request decorators, chains, and repeats #98
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Hey @pcantrell, thanks for implementing this functionality. The project I was working on is done now, we ended up using a different API lib to accomplish what we were trying to do. I'm definitely going to use Siesta in the future to give this a try! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers three related areas of functionality:
Configuration.decorateRequests(...)
replacesbeforeStartingRequest
, and allows you to replace requests based on configuration instead of just listening to them.Request.chained(...)
allows you to chain multiple requests together and have them behave as if they were one request.Request.repeated()
allows you to send a request again, picking up configuration changes.Putting it all together, this allows you to configure sophisticated service-wide retry behavior. For example, this hypothetical code automatically renews auth tokens and retries unauthorized requests for a whole service:
@vdka and @jyounus: This should give you at least some of what you are looking for with #48.
This work is a first draft. Kick the tires!