Skip to content

Commit

Permalink
fix: rate calculation (#2128)
Browse files Browse the repository at this point in the history
  • Loading branch information
@Sekhmet
Sekhmet committed Nov 28, 2018
1 parent dfb4388 commit 54ef44f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/client/app/appActions.js
View file
Expand Up @@ -34,7 +34,7 @@ export const getRate = () => (dispatch, getState, { steemAPI }) => {
payload: {
promise: steemAPI
.sendAsync('get_current_median_history_price', [])
.then(resp => parseFloat(resp.base)),
.then(resp => parseFloat(resp.base) / parseFloat(resp.quote)),
},
});
};
Expand Down

2 comments on commit 54ef44f

@economicstudio
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Thank you for your work.

I came here cause I was wondering why this takes so long. I understand that you guys have a hard time due to crypto bear market. But this kind of simple bug should be fixed very quick. Maybe you might have waited for Steemit to change their feed api.

Hope this commit will be applied very soon. Thank you.

ps. what happens if quote is 0 due to some errors. I guess there is no serious problem since this is just a UI layer, but I asked just in case.

@Sekhmet
Copy link
Contributor Author

@Sekhmet Sekhmet commented on 54ef44f Dec 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are always open for PRs.

Please sign in to comment.