Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite json_metadata.app when edit a post on Busy #1706

Closed
bonustrack opened this issue Apr 5, 2018 · 4 comments
Closed

Overwrite json_metadata.app when edit a post on Busy #1706

bonustrack opened this issue Apr 5, 2018 · 4 comments

Comments

@bonustrack
Copy link
Contributor

It seem we only set the param json_metadata.app when user publish a post, but not when user edit his post on Busy. That should be the case.

@bonustrack bonustrack added this to the v2.5 milestone Apr 5, 2018
@Sekhmet
Copy link
Contributor

Sekhmet commented Apr 5, 2018

Won't it cause problems if an app uses json_metadata.app to categorize posts?

@bonustrack
Copy link
Contributor Author

@Sekhmet I don't think 3p app use json_metada.app to filter post because steemit.com is already overwriting this field

@bonustrack bonustrack modified the milestones: v2.5, v2.6 Apr 7, 2018
@bonustrack bonustrack added this to TODO ✅ in Workflow Apr 9, 2018
@bonustrack bonustrack moved this from TODO ✅ to Backlog 💡 in Workflow Apr 9, 2018
@Sekhmet
Copy link
Contributor

Sekhmet commented Apr 14, 2018

Alright,

it should be fixed by changing priority of metadata tags (we should get original metadata tags first, and then apply ours).

let metaData = {
community: 'busy',
app: `busy/${version}`,
format: 'markdown',
};
// Merging jsonMetadata makes sure that users don't lose any metadata when they edit post using
// Busy (like video data from DTube)
if (this.props.draftPosts[this.draftId] && this.props.draftPosts[this.draftId].jsonMetadata) {
metaData = {
...metaData,
...this.props.draftPosts[this.draftId].jsonMetadata,
};
}

@emre
Copy link
Contributor

emre commented Apr 21, 2018

I am on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants