Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video thumbnail used as post thumbnail looks bad (blue overlay with play button) #1749

Closed
Gandalf-the-Grey opened this issue Apr 14, 2018 · 2 comments

Comments

@Gandalf-the-Grey
Copy link

I've just sent a note to @heiditravels that she unnecessarily includes picture with video preview on top of a post in addition to embedded video because nowadays both steemit and busy are smart enough to make a post thumbnail using video thumbnail.
The problem is that when she does that, there are two almost similar pictures in a post body, one next to another.
Then I noticed that while it is redundant in a post body, it looks way better on a preview page.

Expected behavior

Thumbnails of posts with youtube videos should look similar to regular thumbnails of photos, i.e. without blue overlay.

Actual behavior

When user adds link to video, it is with a blue overlay and a play button on a thumbnail view, thus previews looks really bad.

How to reproduce

This looks good:
https://busy.org/@heiditravels
heiditravels_thumbnails

This looks bad:
https://busy.org/@gtg
gtg_thumbnails

I get that unlike Steemit, busy can play those videos straight from a preview (which is cool feature by the way) however, users have to chose whether they want good looking preview image or instant-play feature (Heidi's videos can't be played from preview because she uses thumbnails instead. Either than or playable, but ugly looking preview)

So maybe no blue overlay and much much more subtle play button?

@Sekhmet
Copy link
Contributor

Sekhmet commented Apr 14, 2018

Thanks for reporting this.
Turns out we can use different thumbnail URL to get preview in 16:9 format.
We need to update embedjs for this.

https://img.youtube.com/vi/VIDEO_ID/mqdefault.jpg - this URL returns 16:9 image.

@emre
Copy link
Contributor

emre commented Apr 21, 2018

Proposed the ratio change on busyorg/embedjs#10.

However, it still doesn't solve the "blue ugly overlay". :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants