Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate comment when showing more replies from a nested comment page #2058

Closed
jrawsthorne opened this issue Jul 11, 2018 · 2 comments
Closed
Assignees

Comments

@jrawsthorne
Copy link
Contributor

Expected behavior

When I click show more comments only 1 of each comment should be shown.

Actual behavior

When I click show more comments the comment I was viewing is duplicated

How to reproduce

Recording of the bug

https://streamable.com/2xn0o

Blue highlight

https://streamable.com/s777n

@Sekhmet Sekhmet self-assigned this Jul 11, 2018
@Sekhmet Sekhmet added the bug label Jul 11, 2018
@Sekhmet Sekhmet added this to the v2.5.2 milestone Jul 11, 2018
@Sekhmet Sekhmet removed the bug label Jul 11, 2018
@Sekhmet
Copy link
Contributor

Sekhmet commented Jul 11, 2018

To be honest I don't know how should it work.
I don't think removing pinned comment or comment from the tree below makes sense (especially the latter as it breaks the discussion tree). If you click Show more button it should show more, but not remove pinned post.

What do you think should happen in this case?

@Sekhmet Sekhmet removed this from the v2.5.2 milestone Jul 11, 2018
@jrawsthorne
Copy link
Contributor Author

The page moves and highlights the comment you originally visited so I don't see why the duplicate one above still needs to be there but I see where you're coming from.

@Sekhmet Sekhmet closed this as completed Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants