Add User Activity Page to current user and all users profiles #1006
Conversation
jm90m
changed the title
* only display 100 actions at a time
|
Great work!
|
…ActivityActions, add % upvotes/downvotes with tooltip, refactor out some messages to components
|
@Sekhmet I kinda like the bold with the text, i feel like it looks aesthetically nicer
VS
@bonustrack what do you think? We should get Paresh's opinion also |
* fix right side bar blocks from overflowing * create another filter group -> Reward, -> author reward, claim reward- curation reward * use + and - circles for filter activities * titles moves on open and close
src/activity/CustomJSONMessage.js
Outdated
| /> | ||
| ); | ||
| } else if (customActionType === accountHistoryConstants.REBLOG) { | ||
| if (currentUsername === customActionDetails.account) { |
There was a problem hiding this comment.
Looks like this if is not necessary. We can add this condition to else if.
There was a problem hiding this comment.
I see what you mean, looks like when you get account history of a user, the reblog actions that you get are only for that current user
src/wallet/ClaimRewardsBlock.js
Outdated
| @@ -55,7 +55,7 @@ class ClaimRewardsBlock extends Component { | |||
| rewardClaimed: true, | |||
| }); | |||
| this.props.getUserAccountHistory(name); | |||
| this.props.updateAuthUser(name); | |||
| setTimeout(() => this.props.updateAuthUser(name), 2000); | |||
There was a problem hiding this comment.
Shouldn't we just chain this after getUserAccountHistory succeeded instead of timeouts?
this.props.getUserAccountHistory(name).then(...);
There was a problem hiding this comment.
good idea will update
src/wallet/walletReducer.js
Outdated
| @@ -118,6 +124,12 @@ export default function walletReducer(state = initialState, action) { | |||
| ...state, | |||
| loadingEstAccountValue: false, | |||
| }; | |||
|
|
|||
There was a problem hiding this comment.
We usually don't have blank lines between cases.
…og logic, remove spaces in cases in reducer
|
@Sekhmet made updates just now based on your feedback |
Currently WIP, just opening PR so I can get feedback on design / layout as I make progress on this.
Fixes #995
Changes:
userHasMoreActionsfrom reducers rather than its own component state