Add voting slider to comments #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor CommentFooter and Buttons from Comment component - Add voting slider to comments
|
Great work! Working well. In the worst case scenario (a subcomment in small screen) the voting slider will be little bit small: |
This changes font-size of vote value info and updates paddings on small screens to make Voting Slider less cluttered
|
I have updated Voting Slider styles so it looks nicer on mobile. |
jm90m
reviewed
Nov 6, 2017
| parseFloat(comment.pending_payout_value) + | ||
| parseFloat(comment.total_payout_value) + | ||
| parseFloat(comment.curator_payout_value); | ||
| const voteRshares = comment.active_votes.reduce((a, b) => a + parseFloat(b.rshares), 0); |
There was a problem hiding this comment.
shouldnt this be voterShares ?
There was a problem hiding this comment.
They are actually called rshares so I think voteRshares is okay-ish name
jm90m
reviewed
Nov 6, 2017
|
|
||
| &__count { | ||
| margin-right: 8px; | ||
| color: #99aab5; |
jm90m
approved these changes
Nov 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #998.
Changes:
ButtonsandCommentFooterout ofCommentcomponent