Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper steps in Dockerfile build #1065

Merged
merged 2 commits into from
Nov 17, 2017
Merged

Conversation

Sekhmet
Copy link
Contributor

@Sekhmet Sekhmet commented Nov 10, 2017

Fixes #1064

Changes:

  • Remove make, g++, and python installation.
  • Change yarn to npm.
  • Add npm run build step.

@bonustrack
Copy link
Contributor

@shreyasgune1 does the Dockerfile work for you with this update?

@bonustrack bonustrack temporarily deployed to busy-nd-pr-1065 November 11, 2017 14:09 Inactive
@Sekhmet
Copy link
Contributor Author

Sekhmet commented Nov 11, 2017

@bonustrack I have tested it myself first and it failed (it had to), it works on new Dockerfile

@shreyasgune1
Copy link

@bonustrack

I tested it on my office machine. Will rest tommorow.

@shreyasgune1
Copy link

Tested docker build with new dockerfile. This time it refuses to even build. The warnings are:

PS C:\Users\Mr. Shreyas\documents\codes\busy> docker build busy
Sending build context to Docker daemon  53.89MB
Step 1/8 : FROM node:alpine
Get https://registry-1.docker.io/v2/: dial tcp: lookup registry-1.docker.io on [::1]:53: read udp [::1]:37375->[::1]:53:
 read: connection refused

@shreyasgune1
Copy link

However, I get the same error on same step in using older dockerfile also.

It appears something else is wrong.....

@Sekhmet
Copy link
Contributor Author

Sekhmet commented Nov 13, 2017

You should be running docker build . as you are already in busy folder.

@shreyasgune1
Copy link

shreyasgune1 commented Nov 13, 2017 via email

@bonustrack bonustrack temporarily deployed to busy-nd-pr-1065 November 16, 2017 15:16 Inactive
@Sekhmet
Copy link
Contributor Author

Sekhmet commented Nov 16, 2017

@shreyasgune1 any progress?

@shreyasgune1
Copy link

shreyasgune1 commented Nov 17, 2017 via email

@Sekhmet
Copy link
Contributor Author

Sekhmet commented Nov 17, 2017

As I mentioned I tested it on my machine and works properly.
I think we can merge that.
cc @bonustrack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants