-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use proper steps in Dockerfile build #1065
Conversation
@shreyasgune1 does the Dockerfile work for you with this update? |
@bonustrack I have tested it myself first and it failed (it had to), it works on new Dockerfile |
I tested it on my office machine. Will rest tommorow. |
Tested docker build with new dockerfile. This time it refuses to even build. The warnings are:
|
However, I get the same error on same step in using older dockerfile also. It appears something else is wrong..... |
You should be running |
Ok I'll try!
…On Mon, Nov 13, 2017 at 1:58 PM, Wiktor Tkaczyński ***@***.*** > wrote:
You should be running docker build . as you are already in busy folder.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1065 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AUKJfBAp5rtlIojXZENsCE7263lxJom5ks5s1_2hgaJpZM4QaPvA>
.
--
Regards,
Shreyas Gune
Assistant Director
National Mission for Clean Ganga
|
@shreyasgune1 any progress? |
Can't seem to get the app running. Tried many things. The problem seems to
be that docker-machine is not running. To run it, hyper V needs to be
enabled. To enable that, a lot of memory is required which I don't have.
Please test the issue at your end. Thank You.
…On Fri, Nov 17, 2017 at 2:14 AM, Wiktor Tkaczyński ***@***.*** > wrote:
@shreyasgune1 <https://github.com/shreyasgune1> any progress?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1065 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AUKJfP0immqF4tmuB15lbJr4HBNaknUZks5s3J6UgaJpZM4QaPvA>
.
--
Regards,
Shreyas Gune
Assistant Director
National Mission for Clean Ganga
|
As I mentioned I tested it on my machine and works properly. |
Fixes #1064
Changes:
make
,g++
, andpython
installation.yarn
tonpm
.npm run build
step.