Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server-Side Rendering #1089

Merged
merged 27 commits into from
Nov 25, 2017
Merged

Server-Side Rendering #1089

merged 27 commits into from
Nov 25, 2017

Conversation

Sekhmet
Copy link
Contributor

@Sekhmet Sekhmet commented Nov 17, 2017 •
edited
Loading

Fixes #1023
Fixes #877

Changes:

  • Separate client and server in src folder.
  • Add common folder.
  • Rewrite Express.js code
  • Add fetchData static methods.
  • Remove legacy needs code.
  • Handle crashes.
  • Isomorphic analytics.
  • Fix UserMenu sidebars.
  • Authenticate and load user language before rendering page (prevent flickering of non-translated content).
  • Use Busy logo as placeholder

@bonustrack bonustrack temporarily deployed to busy-nd-pr-1089 November 17, 2017 12:51 Inactive
@bonustrack bonustrack temporarily deployed to busy-nd-pr-1089 November 17, 2017 18:34 Inactive
@bonustrack bonustrack temporarily deployed to busy-nd-pr-1089 November 17, 2017 19:15 Inactive
@bonustrack bonustrack temporarily deployed to busy-nd-pr-1089 November 17, 2017 19:26 Inactive
@bonustrack bonustrack temporarily deployed to busy-nd-pr-1089 November 19, 2017 22:30 Inactive
@bonustrack bonustrack temporarily deployed to busy-nd-pr-1089 November 19, 2017 23:55 Inactive
@Sekhmet Sekhmet self-assigned this Nov 20, 2017
@bonustrack bonustrack temporarily deployed to busy-nd-pr-1089 November 21, 2017 23:51 Inactive
@Sekhmet Sekhmet removed the PR: WIP label Nov 21, 2017
@Sekhmet
Copy link
Contributor Author

Sekhmet commented Nov 21, 2017

I haven't finished everything I wanted to do with SSR just yet, but everything so far works. I would like to merge those changes as quickly as possible, so we don't have two conflicting branches causing problems while merging.
I will continue working on new features on another PR, so we can have SSR on production already and make development easier.

@jm90m
Copy link
Contributor

jm90m commented Nov 22, 2017 •
edited
Loading

Not too familiar with server side rendering stuff, but I've been testing performances for large data sets that get rendered, like in the Activity page. And there seems to be a performance increase, well done: 👍

Compare filtering here: https://busy-nd-pr-1089.herokuapp.com/@timsaid/activity

to filtering on here: https://busy.org/@timsaid/activity

@Sekhmet
Fix login flow on server
4d4e155 
- Initialize SteemConnect
- Move wildcard route to the bottom
@bonustrack
Copy link
Contributor

I have a small loading icon and these scrolls when i open a profile with french locale:
image

https://busy-nd-pr-1089.herokuapp.com/@busy.org
Can you reproduce these issues?

@bonustrack bonustrack temporarily deployed to busy-master-pr-1089 November 22, 2017 12:38 Inactive
@Sekhmet
Copy link
Contributor Author

Sekhmet commented Nov 22, 2017

I have seen this issue (scrollbars) and it was on my todo list, I will fix this shortly.
I will have to take a look at an issue with small loading icon though.

@Sekhmet Sekhmet temporarily deployed to busy-master-pr-1089 November 25, 2017 12:53 Inactive
@Sekhmet Sekhmet changed the base branch from new-design to master November 25, 2017 13:03
@Sekhmet Sekhmet temporarily deployed to busy-master-pr-1089 November 25, 2017 15:53 Inactive
@Sekhmet Sekhmet removed the PR: WIP label Nov 25, 2017
bonustrack
bonustrack approved these changes Nov 25, 2017
View reviewed changes
Copy link
Contributor

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work 👏 , it's working perfectly for me

jm90m
jm90m approved these changes Nov 25, 2017
View reviewed changes
Copy link
Contributor

@jm90m jm90m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, works fine for me!

@Sekhmet Sekhmet merged commit 012930e into busyorg:master Nov 25, 2017
@Sekhmet Sekhmet deleted the ssr branch November 25, 2017 19:15
This was referenced Nov 27, 2017
Closed
Merged
Sekhmet added a commit that referenced this pull request Nov 29, 2017
@Sekhmet
Release 2.1.0 (#1123)
b870ddd 
This PR merges master into stable.
247f256 (HEAD -> master, upstream/master) Fix scroll to comment behaviour (#1083)
cf1c39d Update Czech translation (#1110)
43c7735 Add Sentry's Raven for error handling (#1112)
012930e Server-Side Rendering (#1089)
afed04f Show more decimals for vote percentage, add power down message, simplify activity filter search (#1104)
d1fed2f Update AuthorRewardMessage to calculate vests to SP (#1103)
71cf88a New Crowdin translations (#1101)
@bonustrack bonustrack added this to the v2.1 milestone Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jm90m jm90m jm90m approved these changes

@bonustrack bonustrack bonustrack approved these changes

Assignees

@Sekhmet Sekhmet

Labels
refactor
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sekhmet @jm90m @bonustrack