Add market price on feed for every crypto #1189
Conversation
* Fixes #1170 * Changes: - Add FeedSidebar component & CryptoTrendingCharts component - add cryptosHelper to search for cryptos within the top 100 crypto constants
|
Can we have the a margin-bottom of 10px on the market block? |
|
@bonustrack yup just updated it, please check again, thx |
| `https://min-api.cryptocompare.com/data/histoday?fsym=${symbol}&tsym=USD&limit=7`, | ||
| ).then(res => res.json()); | ||
|
|
||
| class CryptoTrendingCharts extends React.Component { |
There was a problem hiding this comment.
We should avoid having duplicate code, i think this component should also be used on the Steem and SBD market block on wallet pages.
There was a problem hiding this comment.
Steem & SBD market blocks are both combined into one, thats why I kept the SteemTrendingCharts component...
I can make it look like this if you want?
and it's not really duplicate code, since if you look at steem trending charts component, there is a few different logic in there.
There was a problem hiding this comment.
Can't you just make that the component can take an array of symbol instead of only one?
There was a problem hiding this comment.
yeah I can but this would only be for one case? just for this specific scenario? Is that worth doing, when we are going to update the charts design anyways?
There was a problem hiding this comment.
If we are not doing this we are going to update the charts in 2 different places isn't it?
There was a problem hiding this comment.
yeah thats true, I'll see what I can come up with .
|
@bonustrack just updated it so their is now a |
Fixes #1170
Changes: