Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load translations asynchronously #1237

Merged
merged 7 commits into from
Dec 25, 2017
Merged

Load translations asynchronously #1237

merged 7 commits into from
Dec 25, 2017

Conversation

Sekhmet
Copy link
Contributor

@Sekhmet Sekhmet commented Dec 23, 2017 •
edited
Loading

Fixes #1197

Main bundle size decreased 440KB (52% decrease).
Vendor bundle size decreased 100KB (7% decrease).

Changes:

  • Load translations and locale data asynchronously.
  • Handle render on server.
  • Wait for translation to load before rendering page.

@bonustrack bonustrack temporarily deployed to busy-master-pr-1237 December 23, 2017 12:45 Inactive
@bonustrack bonustrack added this to the v2.3 milestone Dec 23, 2017
@Sekhmet Sekhmet mentioned this pull request Dec 23, 2017
Closed
@Sekhmet Sekhmet temporarily deployed to busy-master-pr-1237 December 23, 2017 13:43 Inactive
@Sekhmet Sekhmet temporarily deployed to busy-master-pr-1237 December 23, 2017 18:14 Inactive
@Sekhmet Sekhmet changed the title Load translations asynchronously Load translations asynchronously and respect Accept-Language header Dec 23, 2017
@Sekhmet Sekhmet changed the title Load translations asynchronously and respect Accept-Language header Load translations asynchronously Dec 23, 2017
@Sekhmet Sekhmet removed the PR: WIP label Dec 23, 2017
@Sekhmet Sekhmet temporarily deployed to busy-master-pr-1237 December 23, 2017 23:22 Inactive
@Sekhmet Sekhmet temporarily deployed to busy-master-pr-1237 December 24, 2017 12:09 Inactive
@Sekhmet Sekhmet removed the PR: WIP label Dec 24, 2017
@Sekhmet Sekhmet removed this from the v2.3 milestone Dec 24, 2017
@Sekhmet Sekhmet merged commit b9e05bd into busyorg:master Dec 25, 2017
@Sekhmet Sekhmet deleted the async-translations branch December 25, 2017 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jm90m jm90m jm90m approved these changes

@bonustrack bonustrack bonustrack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sekhmet @jm90m @bonustrack