Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMP error handling #1266

Merged
merged 4 commits into from
Dec 26, 2017
Merged

AMP error handling #1266

merged 4 commits into from
Dec 26, 2017

Conversation

Sekhmet
Copy link
Contributor

@Sekhmet Sekhmet commented Dec 26, 2017

Changes:

  • Check if image is non-null before using it (it causes a lot of unhandledRejections and timeouts).
  • Add catch to handle future errors.
  • Enable debug logs on deployment.

@Sekhmet Sekhmet added the Hotfix label Dec 26, 2017
@bonustrack bonustrack temporarily deployed to busy-master-pr-1266 December 26, 2017 19:50 Inactive
@Sekhmet Sekhmet temporarily deployed to busy-master-pr-1266 December 26, 2017 20:02 Inactive
@Sekhmet Sekhmet merged commit 4a10c7f into busyorg:stable Dec 26, 2017
@Sekhmet Sekhmet deleted the hotfix-amp-error-handling branch December 26, 2017 20:46
@Sekhmet Sekhmet restored the hotfix-amp-error-handling branch December 26, 2017 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonustrack bonustrack bonustrack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sekhmet @bonustrack