Updates styles #1276
Merged
Updates styles #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonustrack
reviewed
Dec 27, 2017
src/client/styles/custom.less
Outdated
| @@ -2,9 +2,11 @@ | |||
|
|
|||
| // Start with assigning color names to specific hex values. | |||
| @white: #fff; | |||
| @white-shadow: rgba(0, 0, 0, 0.11); | |||
There was a problem hiding this comment.
Why 0.11? I prefer 0.05 did you tried?
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| .feed-layout { | |||
| position: relative; | |||
| min-height: 100%; | |||
There was a problem hiding this comment.
Is this supposed to fix the view being cut when feed page is loading? It doesn't seem to work for me
There was a problem hiding this comment.
I'm not sure how to solve this one. I think JM might know how to do this.
There was a problem hiding this comment.
This fix doesnt need to happen in this PR
| height: 56px; | ||
| line-height: 56px; | ||
|
|
||
| &__brand { | ||
| font-size: 28px; | ||
| font-size: 32px; |
bonustrack
approved these changes
Dec 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: