-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile settings #1280
Profile settings #1280
Conversation
|
Also it may be good to allow only alphanumeric + |
So social links shouldn't be URLs but only usernames? How to handle it if users doesn't have username specified (e.g. Facebook)? What do we want to do with Bitcoin/Ethereum? Would it be just address? How do we display it? |
On Facebook if the username is not specified, the id should work. |
Bitcoin Ethereum can send user to their most popular explorer: |
Updated, example profile there: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looked through.
I tested.
I made comments.
you can do whatever you like, they are just suggestions, I'm still sick right now in Japan, but ill try to keep thoroughly reviewing
|
||
SocialLink.propTypes = { | ||
profile: PropTypes.shape({ | ||
id: PropTypes.string.isRequired, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we start defining the properties for certain shapes now for propTypes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we know shape ahead of time, and it doesn't require much work to define properties it might be useful.
src/client/components/SocialLinks.js
Outdated
import _ from 'lodash'; | ||
import SocialLink from './SocialLink'; | ||
|
||
export const socialProfiles = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be good a idea to keep socialProfiles
, socialTransformers
and transform
in a helper / constants file instead of a components file
src/client/components/SocialLinks.js
Outdated
import SocialLink from './SocialLink'; | ||
|
||
export const socialProfiles = [ | ||
{ id: 'facebook', icon: 'facebook', color: '#3b5998', name: 'Facebook' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I noticed we have a lot of colors floating around in our codebase in our javascript files...
would be nice to be keep them in a constants/styles.js
file and import it based on below see jist here:
https://gist.github.com/jm90m/933417aaf8f1259804957be4df090a91
so import { COLORS }
then you get the color from there, i figure out the color name by using this website http://www.color-blindness.com/color-name-hue/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we have many colour definitions in our JS files. Those are only useful in context of social profiles.
Things is we already have file with colours (less) and I don't think we can combine those two.
Fixes #1256
Changes:
ProfileSettings
.UserInfo
.