New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build process #1825
Build process #1825
Conversation
This reverts commit 4172283.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work that simplify a lot stuff! Tested in local and everything seem to work well, SSR, hot reload, build etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works well for me now, even when making a change, their is no more memory leak
Fixes #1761
Fixes #1601
This should improve workflow when working on the server and make better test environment for E2E tests.
What has changed:
dev
for development,build
for building production app, andstart
to deploy it).Changes
dev
script with hot reloading on both server and client.build
script.dev
,build
andstart
.Test plan
dev
scriptNote: styles are loaded using
style-loader
on development, so there is blink of not styled content after refreshing. It's slight inconvenience, but it allows styles to be hot-reloadable.yarn
.yarn dev
.app.get('/*', ssrHandler);
out inapp.js
).Cannot GET /
).build
andstart
scriptyarn
.yarn build
.yarn start
.Compare bundle size:
This PR: https://busy-master-pr-1825.herokuapp.com/statistics.html
Staging: https://staging.busy.org/js/statistics.html
Overall bundle size decreased by small amount (few KB).