Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work on 24.5.1 #60

Closed
develuppro opened this issue Jun 13, 2024 · 4 comments · Fixed by #62
Closed

Does not work on 24.5.1 #60

develuppro opened this issue Jun 13, 2024 · 4 comments · Fixed by #62
Assignees

Comments

@develuppro
Copy link

Hi. Can you check new version sentry 24.5.1 ?

@butorov
Copy link
Owner

butorov commented Jun 13, 2024

Hi @develuppro!
Do you have any logs or error traces displaying the problem?
I'm going to check the compatibility soon. Most probably this weekend or the next week.

@develuppro
Copy link
Author

@butorov
error

@cgabriel
Copy link

Confirmed on 24.5.1 too, same error in the log reported by @develuppro

@butorov
Copy link
Owner

butorov commented Jun 27, 2024

Hi @develuppro and @cgabriel.
The issue is fixed in the 0.6.0 version of the plugin. I tested it on my Sentry 24.5.1 (will have the ability to check it on 24.6.0 soon). Feel free to update.
Thank you for reporting!

The thing was as in getsentry/sentry#71880 Sentry's team has changed the signature of a safe_execute() function, which I use in a way, similar to the built-in plugins. The change affected built-in integrations/plugins as well.
The whole pull request shows that we can continue using the updated function with no worries.

@butorov butorov closed this as completed Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants