Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translated subclass #11

Merged
merged 6 commits into from
Mar 18, 2020
Merged

translated subclass #11

merged 6 commits into from
Mar 18, 2020

Conversation

buttercrab
Copy link
Owner

No description provided.

@buttercrab buttercrab self-assigned this Mar 18, 2020
@jshyunbin
Copy link
Collaborator

1048줄 번역에 오역이 있습니다.

@jshyunbin
Copy link
Collaborator

jshyunbin commented Mar 18, 2020 •
edited by buttercrab
Loading

"cls나 상속된 모든 것들 중에 False가 아닌 것들을 찾습니다."
이게 맞는 번역인것 같네요

@gs18113
Copy link
Collaborator

gs18113 commented Mar 18, 2020

원문이 "cls or anything it inherits from"이니까,
"cls나 그것이 상속하는 클래스들에서 거짓이 아닌 "__hash__" 메소드를 찾습니다."
가 오해의 소지가 없지 않을까요?

@buttercrab
Copy link
Owner Author

그럼 "cls나 이의 조상 클래스에서 거짓이 아닌 "__hash__" 메소드를 찾습니다"라고 할까요?

@gs18113
Copy link
Collaborator

gs18113 commented Mar 18, 2020

네 그것도 괜찮을 것 같네요.

jshyunbin
jshyunbin approved these changes Mar 18, 2020
View reviewed changes
Copy link
Collaborator

@jshyunbin jshyunbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@buttercrab buttercrab merged commit 5346a67 into 3.0 Mar 18, 2020
@buttercrab buttercrab deleted the translate branch March 18, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooogi123 wooogi123 wooogi123 approved these changes

@gs18113 gs18113 gs18113 approved these changes

@jshyunbin jshyunbin jshyunbin approved these changes

@myeongjinshin myeongjinshin Awaiting requested review from myeongjinshin

Assignees

@buttercrab buttercrab

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@buttercrab @jshyunbin @gs18113 @wooogi123