fix: Correct identification of early Satisfyer devices #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change passes the ProtocolCommunicationSpecifier down into ProtocolIdentifier::identify(), which affects all protocols, but means that the identify() method can access the same data that was used to decide that this was a suitable protocol implementation in the first place. Fixes buttplugio#547
blackspherefollower
force-pushed
the
protocol-work
branch
from
2e8f527
to
275d8d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change passes the ProtocolCommunicationSpecifier down into ProtocolIdentifier::identify(), which affects all protocols, but means that the identify() method can access the same data that was used to decide that this was a suitable protocol implementation in the first place.
Fixes #547