Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: byte as argument for string conversion #27

Merged
merged 2 commits into from
May 27, 2023
Merged

fix: byte as argument for string conversion #27

merged 2 commits into from
May 27, 2023

Conversation

butuzov
Copy link
Owner

@butuzov butuzov commented May 27, 2023

No description provided.

@viezly
Copy link

viezly bot commented May 27, 2023 •
edited

Changes preview:

Legend:

👀 Review pull request on Viezly

@butuzov
fix: fix for issue #26
62e1471 
we going to ignore other types than []byte while doing conversion
@github-actions
Copy link

Pull Request Test Coverage Report for Build 5099566699

  • 5 of 7 (71.43%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.6%) to 94.444%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checker/checker.go 5 7 71.43%
Files with Coverage Reduction New Missed Lines %
internal/checker/checker.go 1 87.01%
Totals Coverage Status
Change from base Build 5065541021: -0.6%
Covered Lines: 289
Relevant Lines: 306
💛 - Coveralls

@butuzov butuzov merged commit 9bcfd19 into main May 27, 2023
@butuzov butuzov deleted the issue-26 branch May 27, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@butuzov