Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get current user info from meta tag instead of body #512

Merged
merged 1 commit into from
Apr 28, 2018
Merged

Get current user info from meta tag instead of body #512

merged 1 commit into from
Apr 28, 2018

Conversation

jamesmosier
Copy link
Contributor

@jamesmosier jamesmosier commented Apr 28, 2018 •
edited
Loading

Description

Fixes #508. Bitbucket changed how where they render the data-current-user attribute. It has been moved from the body tag to its own meta tag directly inside the <head>.

Proposal

Instead of selected the data-current-user from the body, grab it from the meta instead.

@buunguyen buunguyen changed the title get current user info from meta tag instead of body Get current user info from meta tag instead of body Apr 28, 2018
@buunguyen
Copy link
Collaborator

Thank you!

@buunguyen buunguyen merged commit 313cd81 into ovity:master Apr 28, 2018
@jamesmosier
Copy link
Contributor Author

@buunguyen when will this change be deployed to the Chrome Web Store? If there is anything I can do to help I'd be glad to assist.

@dmbaranov
Copy link

True, would be good if author can update extension in the Chrome Web Store. Until that, you can download the source code and install unpacked extension yourself. Just run yarn build, after that yarn dist. Once it's finished, go to the dist folder and extract chrome.zip. When done, go to chrome://extensions, turn on Developer mode, press Load unpacked button and select the extracted chrome folder. Should work like a charm :)

P.S. I assume that you're @Jamez14 an experienced developer and this guide might be no that helpful for you. But it could be helpful for someone who'll find this pull request :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesmosier @buunguyen @dmbaranov