SleepScoreMaster update: use Power Spectrum Slope #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dumb question - I use my own fork. How do I get this pull request into my own fork to try it? Or do I have to use the main fork? |
|
Hm - let's pull it into dev and you can check it there? If you want to try it before pulling, you might be able to open a pull request from my fork |
|
I'm fine with it in Dev. But I'm also more cavalier than some
…On Mon, Oct 29, 2018 at 12:27 PM Dan Levenstein ***@***.***> wrote:
Hm - let's pull it into dev and you can check it there? If you want to try
it before pulling, you might be able to open a pull request from my fork
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#265 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADXrTforaZcDObWXl90WhnJa6_juHhSCks5upyxxgaJpZM4X_e5j>
.
|
|
Oh yeah I can do from your fork to mine!. Will do that.
On Mon, Oct 29, 2018 at 12:28 PM Brendon Watson <brendon.watson@gmail.com>
wrote:
… I'm fine with it in Dev. But I'm also more cavalier than some
On Mon, Oct 29, 2018 at 12:27 PM Dan Levenstein ***@***.***>
wrote:
> Hm - let's pull it into dev and you can check it there? If you want to
> try it before pulling, you might be able to open a pull request from my fork
>
> —
> You are receiving this because your review was requested.
> Reply to this email directly, view it on GitHub
> <#265 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ADXrTforaZcDObWXl90WhnJa6_juHhSCks5upyxxgaJpZM4X_e5j>
> .
>
|
|
Merging. If we find PSS to be worse than SWWeights after people have tried it out, we can change the default back to SWWeights. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to the SleepScoreMaster algorithm for NREM detection - it adds the ability to use the slope of the (log-log) power spectrum (i.e. the 1/f exponent). So far I've found this to be more reliable in non-frontal cortex recordings and with noise, so I made it default (the previous weight method is still also available with SWWeights), but am hoping some people will try it out on their data as well.
Repull #262