Fix issue of select items not being rendered.

When trying out demo, only the first few items were being rendered propery. Checked to see if it had to do with the loading order of the css packages, but that wasn't it. Demo was fixed by building them with the demo package. In order to do this I removed the include property to allow webpack to pull from node_modules.
bvaughn · Oct 31, 2016 · 05a02e9 · 05a02e9
1 parent 74e10fe
commit 05a02e9
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 10 deletions.
diff --git a/index.html b/index.html
@@ -9,9 +9,7 @@
     <link type="image/x-icon" rel="shortcut icon" />
 
     <link rel="stylesheet" type="text/css" href="https://unpkg.com/react-select/dist/react-select.css" />
-    <link rel="stylesheet" type="text/css" href="https://unpkg.com/react-virtualized/styles.css" />
-    <link rel="stylesheet" type="text/css" href="https://unpkg.com/react-virtualized-select/styles.css" />
-    <link rel="stylesheet" type="text/css" href="./styles.css" />
+    <link rel="stylesheet" type="text/css" href="static/styles.css" />
   </head>
   <body>
     <div id="root"></div>

diff --git a/source/demo/Application.js b/source/demo/Application.js
@@ -2,6 +2,8 @@ import React, { Component } from 'react'
 import ReactDOM from 'react-dom'
 import VirtualizedSelect from 'react-virtualized-select'
 import createFilterOptions from '../index'
+import 'react-virtualized/styles.css'
+import 'react-virtualized-select/styles.css'
 
 const STRINGS = ['foo', 'bar', 'baz', 'qux']
 

diff --git a/webpack.config.demo.js b/webpack.config.demo.js
@@ -32,8 +32,7 @@ module.exports = {
       },
       {
         test: /\.css$/,
-        loaders: ['style', 'css?importLoaders=1'],
-        include: path.join(__dirname, 'styles.css')
+        loaders: ['style', 'css?importLoaders=1']
       }
     ]
   }

diff --git a/webpack.config.dev.js b/webpack.config.dev.js
@@ -35,8 +35,7 @@ module.exports = {
       },
       {
         test: /\.css$/,
-        loaders: ['style', 'css?importLoaders=1'],
-        include: path.join(__dirname, 'source')
+        loaders: ['style', 'css?importLoaders=1']
       }
     ]
   },

diff --git a/webpack.config.umd.js b/webpack.config.umd.js
@@ -39,9 +39,7 @@ module.exports = {
       },
       {
         test: /\.css$/,
-        loader: ExtractTextPlugin.extract('css-loader!autoprefixer-loader?{browsers:["last 2 version", "Firefox 15"]}'),
-        include: path.join(__dirname, 'source')
-
+        loader: ExtractTextPlugin.extract('css-loader!autoprefixer-loader?{browsers:["last 2 version", "Firefox 15"]}')
       }
     ]
   }