use 'registerChild' as ref in registerChild example #1814
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
registerChild
example in CellMeasurer, we never useregisterChild
. From looking around some, I believe one valid use is to pass it asref={registerChild}
, which I do here.I'm still quite unsure of this PR but it seems to match most of the examples I've found. And the current state of the docs seems quite weird/confusing, as we introduce this param then don't use it. I hope this PR makes sense, & please forgive me if not.
One example of another user here following this pattern is this comment: #1572 (comment)
yarn run prettier
).