Skip to content

Commit

Permalink
RN findNodeHandle no longer adds props directly to read-only owner (f…
Browse files Browse the repository at this point in the history
  • Loading branch information
bvaughn committed Aug 23, 2017
1 parent 27a1e22 commit faa246f
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions src/renderers/native/findNodeHandle.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ if (__DEV__) {
}

import type {Fiber} from 'ReactFiber';
import type {ReactInstance} from 'ReactInstanceType';

/**
* ReactNative vs ReactWeb
Expand Down Expand Up @@ -60,11 +59,10 @@ import type {ReactInstance} from 'ReactInstanceType';
// accidentally deep-requiring this version.
function findNodeHandle(componentOrHandle: any): any {
if (__DEV__) {
// TODO: fix this unsafe cast to work with Fiber.
var owner = ((ReactCurrentOwner.current: any): ReactInstance | null);
if (owner !== null) {
var owner = ReactCurrentOwner.current;
if (owner !== null && owner.stateNode !== null) {
warning(
owner._warnedAboutRefsInRender,
owner.stateNode._warnedAboutRefsInRender,
'%s is accessing findNodeHandle inside its render(). ' +
'render() should be a pure function of props and state. It should ' +
'never access something that requires stale data from the previous ' +
Expand All @@ -73,7 +71,7 @@ function findNodeHandle(componentOrHandle: any): any {
getComponentName(owner) || 'A component',
);

owner._warnedAboutRefsInRender = true;
owner.stateNode._warnedAboutRefsInRender = true;
}
}
if (componentOrHandle == null) {
Expand Down

0 comments on commit faa246f

Please sign in to comment.