Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherited settings from template first #7

Closed
wants to merge 1 commit into from

Conversation

deepj
Copy link

@deepj deepj commented Jan 17, 2013

I think settings of template should be inherited first. We have many prepared templates and we don't need to re-setup cpus, memory or networks when these ones stored in templates.

@rubiojr
Copy link
Contributor

rubiojr commented Jan 18, 2013

@deepj, thanks.

I think the patch makes sense in general, but it probably breaks current behavior, potentially breaking some of our tools at least.

I need to have a closer look at it, but this kind of interface change is more suitable for a future 2.X release perhaps.

@deepj
Copy link
Author

deepj commented Jan 21, 2013

OK. Thanks

@rubiojr
Copy link
Contributor

rubiojr commented Jan 21, 2013

Thanks for understanding @deepj.

I do have plans to incorporate as much of your code as I can but since knife-esx is lacking test code it's going to take more time than expected to test for backwards compatibility.

@deepj
Copy link
Author

deepj commented Jan 25, 2015

@rubiojr I think this can be closed. I don't use knife anymore or have an access to Xen Server

@deepj deepj closed this Feb 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants