Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image argument #4

Merged
merged 6 commits into from
Sep 16, 2022
Merged

Image argument #4

merged 6 commits into from
Sep 16, 2022

Conversation

bvreede
Copy link
Owner

@bvreede bvreede commented Sep 16, 2022 •
edited
Loading

This PR adds the functionality of a argument parser. There is also an additional image to play with.

Try it out:

python imtascii.py cat.png

or:

python imtascii.py dog.jpeg

Closes #3

This PR should be merged only after dealing with #1

@bvreede bvreede marked this pull request as draft September 16, 2022 09:49
@bvreede bvreede marked this pull request as ready for review September 16, 2022 09:50
geek-yang
geek-yang requested changes Sep 16, 2022
View reviewed changes
Copy link
Collaborator

@geek-yang geek-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bvreede Good job! The code works well. But I notice that the new changes are not mentioned in the README.md. Please update README.md. I made some small changes to you code, please take a look. Thanks! 😄

imtascii.py Show resolved Hide resolved
imtascii.py Outdated Show resolved Hide resolved
imtascii.py Outdated Show resolved Hide resolved
@bvreede
Copy link
Owner Author

bvreede commented Sep 16, 2022

Thanks so much @geek-yang for reviewing! I have addressed your comments.

geek-yang
geek-yang approved these changes Sep 16, 2022
View reviewed changes
Copy link
Collaborator

@geek-yang geek-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bvreede Thanks for the changes! It looks awesome! Let's go ahead and merge this PR!

@bvreede bvreede merged commit b4fb77a into main Sep 16, 2022
@bvreede bvreede deleted the image-argument branch September 16, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geek-yang geek-yang geek-yang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use image on command line to process any picture
2 participants
@bvreede @geek-yang