Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playstation Vita port #110

Merged
merged 29 commits into from
Mar 6, 2019
Merged

Playstation Vita port #110

merged 29 commits into from
Mar 6, 2019

Conversation

devnoname120
Copy link
Contributor

@devnoname120 devnoname120 commented Mar 2, 2019

Here are changes allowing to run Julius on a Playstation Vita device.

Screenshots:

Notes:

  • Lots of commits, because I tried different approaches (e.g. SDL for rendering, then switched to a native Vita library for performance reasons). I can squash them once this pull request is reviewed.
  • @rsn887 did a pull request on top of my changes in order to improve input handling (vita: multiple control enhancements (see below) devnoname120/julius#1). This pull request will be done on https://github.com/bvschaik/julius instead when mine is merged.
  • Performances are pretty good, the game is playable even in big cities. The videos are laggy however.
  • I had to create a wrapper on top of fopen() because Julius relies a lot on chdir()/getcwd() which are not supported on the Vita.
  • It should be possible to automatically compile using Travis with the vitasdk, there is also a Docker container. However, it will not be possible to run automated tests since there is no reliable PS Vita emulator yet. A physical PS Vita running a special program receiving unit tests could theoretically be done but it's a lot of work and a maintenance burden.

@codecov-io
Copy link

codecov-io commented Mar 2, 2019

Codecov Report

Merging #110 into master will increase coverage by <.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
+ Coverage   63.48%   63.49%   +<.01%     
==========================================
  Files         174      174              
  Lines       25182    25188       +6     
==========================================
+ Hits        15988    15994       +6     
  Misses       9194     9194
Impacted Files Coverage Δ
src/game/settings.c 63.68% <ø> (ø) ⬆️
test/sav/sav_compare.c 73.07% <ø> (ø) ⬆️
test/sav/run.c 64.28% <ø> (ø) ⬆️
src/core/io.c 89.18% <100%> (ø) ⬆️
src/core/file.c 14.63% <100%> (+14.63%) ⬆️
src/game/file_io.c 82.87% <66.66%> (ø) ⬆️
src/core/dir.c 36.06% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59459e9...eb4dbd5. Read the comment docs.

src/game/settings.c Outdated Show resolved Hide resolved
src/graphics/video.c Outdated Show resolved Hide resolved
@bvschaik bvschaik merged commit cb21834 into bvschaik:master Mar 6, 2019
@devnoname120 devnoname120 deleted the vita branch March 7, 2019 19:13
attrition pushed a commit to attrition/octavius that referenced this pull request Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants