Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getBuildUnit inconsistency #780

Closed
Venorcis opened this issue Feb 26, 2018 · 1 comment
Closed

getBuildUnit inconsistency #780

Venorcis opened this issue Feb 26, 2018 · 1 comment

Comments

@Venorcis
Copy link

This function is a bit confusing. It has symmetry for SCVs (it returns the building under construction for the SCV or the SCV for the building under construction), but not for other units (it does return the zealot being trained for the gate but it does not return the gate for the zealot being trained). This last case (return the gate that is training the zealot) would be expected to work considering how it works for SCVs, but it does not.

@Venorcis Venorcis changed the title getBuildUnit getBuildUnit inconsistency Feb 26, 2018
@dgant
Copy link
Contributor

dgant commented Feb 26, 2018

"Figure out which building is making which unit by looking for (unit of builder type) with the same position" is done pretty commonly. Having this built-in would be a nice addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants