[WIP] Complete overhaul of the atm sub-package #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there were lots of precision problems regarding the sqrt and squares of various quantities
Unfortunately, the discrete refractive-index layers can lead to caustics in the ray propagation. (See tmp.ipynb)
now, a function atm_layers has to be used to prepare caches for atmospheric layer properties; this potentially speeds up batch jobs significantly, as one needs to calculate the layers just once (could even do tebb in cython now, if necessary)
this needs a lot more testing (and tests)
the smallest possible beta_n angle is now 0.2 arcsec (everything else will be set to 90d or -90d, respectively
bwinkel
force-pushed
the
fixatm
branch
2 times, most recently
from
b0829ba
to
a5fb7cf
Compare
|
Again, there is still a problem with MacOS builds on travis. ("omp.h" not found). As everything else was OK, I'm merging the PR, as the travis issues are unrelated to this PR and should/could be fixed in the master branch afterwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_elevationto find optimal ray geometry (to reach a given target)