Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zupfnoter makes all Keys to Major Key #103

Closed
bwl21 opened this issue Jan 8, 2017 · 0 comments
Closed

Zupfnoter makes all Keys to Major Key #103

bwl21 opened this issue Jan 8, 2017 · 0 comments
Labels
bug to-be-deployed to-be-verified
Milestone
1.6.1

Comments

@bwl21
Copy link
Owner

bwl21 commented Jan 8, 2017

Request

Zupfnoter takes the accidentials an computes the key out of it. But it dos that for Major keys only. So if I enter "Em" as key, Zupfnoter shows "G".

Solution approach

Support "mode" modifier in K: statement as of http://abcnotation.com/wiki/abc:standard:v2.1#description_of_information_fields chapter 3.1.14

Then implement the table to find out the key for the transposed version.

see abc2svg_to_harpnotes method _make_metadata
@bwl21 bwl21 added this to the 1.6xxx milestone Jan 8, 2017
bwl21 added a commit that referenced this issue Mar 12, 2017
@bwl21
#103 Zupfnoter makes all Keys to Major Key
35b0893 
Zupfnoter now handles all scale modes
bwl21 added a commit that referenced this issue Mar 12, 2017
@bwl21
#103 Zupfnoter makes all Keys to Major Key
92f1157 
Zupfnoter now handles all scale modes
bwl21 added a commit that referenced this issue Apr 8, 2017
@bwl21
Merge branch 'feature/#63_new_dropbox-api' into develop
727e101 
* feature/#63_new_dropbox-api:
  see #81 improved auhopositioning of countnotes and barnumbers * on vertical flow draw bar numbers left, and countnotes right * on page border draw countnotes and bar numbers inside * tweak vertical position
  add version information
  Reworked the login approach * removed reconnect from “load_from_localstore (cleanup) * controller now uses reconnect - command * commands dlogin	dreconnect	dlogout working together
  #112 fix filenames with umlauts update to dropbox Api 2.5.1
  refined position of T01_number
  #63 win improved logout, login, but by far not finished
  #63 now we have dlogin and dlogout
  #63 now we have dopen and save
  #63 improved success message on save
  #63 initial attempt to migrate to dropbox API v2
  #63 improved error handling for command dos
  #108 added presets for sheet annotation such as number, extract number, copyrights, etc.
  #100 omit cutmarks on A3
  #42 some fixes for MS-Edge
  #104 zupfnoter now respects treble+8, treble-8 etc.
  #103 Zupfnoter makes all Keys to Major Key
  updated abc2svg fixed css to improve

# Conflicts:
#	30_sources/SRC_Zupfnoter/src/harpnotes.rb
bwl21 added a commit that referenced this issue Apr 24, 2017
@bwl21
updated changes for #121, #119, #103
e24fd2c
@bwl21 bwl21 closed this as completed May 17, 2017
bwl21 added a commit that referenced this issue Oct 23, 2017
@bwl21
No initial render after a crash in previous session #103
ef8dddf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug to-be-deployed to-be-verified
Projects
None yet
Milestone
1.6.1
Development

No branches or pull requests
1 participant
@bwl21