Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rendition of triplets configurable #39

Closed
bwl21 opened this issue Jul 29, 2016 · 1 comment
Closed

Make rendition of triplets configurable #39

bwl21 opened this issue Jul 29, 2016 · 1 comment
Labels
enhancement to-be-verified
Milestone
1.5

Comments

@bwl21
Copy link
Owner

bwl21 commented Jul 29, 2016

Request

Triplets somtimes look ugly, in particular if they are not monotoneous.

Approach

  1. Let user drag the triplet "3" and compute the Controlpoints of the Bezier-curve accordingly.
  2. Analyze all pitches of the triplet and optimize the rendition.
  3. use big curly braces for triplets instead of Bezier-Curves
  4. ...
bwl21 added a commit that referenced this issue Aug 1, 2016
@bwl21
#39 Improve tuplets
04e199c 
Now properly handle (3:2:2 C2C
bwl21 added a commit that referenced this issue Aug 1, 2016
@bwl21
#39 explicitly handle the style of annotations.
8c6a5d6 
This was an attempt to make the reference sheet colorful. But nevertheless
the default style of annotations should not be handled in the layout
but when creating the annotation.

I commit this here even, if it does not directly relate to #39
bwl21 added a commit that referenced this issue Aug 1, 2016
@bwl21
#39 now the shape of tuplet curve can be configured. See controller.r…
eaca2ff 
…b for details.
bwl21 added a commit that referenced this issue Aug 1, 2016
@bwl21
#39 tuplet configuration is now outside a first level configuration i…
a19c348 
…n an extract.

It also works independent from a voice such that tuplets can be labeled according
to tuplet patterns.

Not sure if concerns are separated good enough by this approach.
Common configuration of tupelos may also imply a common configuration
of annotations.

Therefore this is an intermediate implementation.
bwl21 added a commit that referenced this issue Aug 1, 2016
@bwl21
#39 tuplet configuration is now outside a first level configuration i…
6840271 
…n an extract.

It also works independent from a voice such that tuplets can be labeled according
to tuplet patterns.

Not sure if concerns are separated good enough by this approach.
Common configuration of tupelos may also imply a common configuration
of annotations.

Therefore this is an intermediate implementation.

Tuplet curves are now thin
bwl21 added a commit that referenced this issue Aug 1, 2016
@bwl21
Merge branch 'feature/#39_improve_tuplets' into develop
c951899 
* feature/#39_improve_tuplets:
  #39 tuplet configuration is now outside a first level configuration in an extract. It also works independent from a voice such that tuplets can be labeled according to tuplet patterns.
  #39 tuplet configuration is now outside a first level configuration in an extract. It also works independent from a voice such that tuplets can be labeled according to tuplet patterns.
  #39 now the shape of tuplet curve can be configured. See controller.rb for details.
  #39 explicitly handle the style of annotations. This was an attempt to make the reference sheet colorful. But nevertheless the default style of annotations should not be handled in the layout but when creating the annotation.
  #39 Improve tuplets
bwl21 added a commit that referenced this issue Aug 1, 2016
@bwl21
#39 now the tuplet note is draggable also optimized the automatic pos…
5459f18 
…itioning
@bwl21
Copy link
Owner Author

bwl21 commented Aug 1, 2016

I leave this open, since it is still experminental

@bwl21 bwl21 added this to the 1.5 milestone Aug 23, 2016
@bwl21 bwl21 closed this as completed Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement to-be-verified
Projects
None yet
Milestone
1.5
Development

No branches or pull requests
1 participant
@bwl21