Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typo] var "EndpointGuildInvites" in discordgo/endpoints.go #440

Closed
jcmdln opened this issue Sep 7, 2017 · 2 comments
Closed

[Typo] var "EndpointGuildInvites" in discordgo/endpoints.go #440

jcmdln opened this issue Sep 7, 2017 · 2 comments
Milestone

Comments

@jcmdln
Copy link

jcmdln commented Sep 7, 2017

It appears that EndpointGuildInvites is declared twice, though there is a typo in the first declaration on line 74:

...
	EndpointGuildInivtes         = func(gID string) string { return EndpointGuilds + gID + "/invites" }

Later on line 86:

...
	EndpointGuildInvites         = func(gID string) string { return EndpointGuilds + gID + "/invites" }
...

It appears that the only other mention of this variable is on line 910 of discordgo/restapi.go, but if I'm not mistaken this is in fact a typo and should be corrected?

	body, err := s.RequestWithBucketID("GET", EndpointGuildInvites(guildID), nil, EndpointGuildInivtes(guildID))
@iopred
Copy link
Collaborator

iopred commented Sep 7, 2017 via email

therealfakemoot added a commit to therealfakemoot/discordgo that referenced this issue Sep 7, 2017
Reference Issue: bwmarrin#440
This endpoint was declard twice in endpoints.go, and used in the
GuildInvites() method on Session values. I replaced the misspelled
invocation.

All tests pass.
iopred pushed a commit that referenced this issue Sep 7, 2017
Reference Issue: #440
This endpoint was declard twice in endpoints.go, and used in the
GuildInvites() method on Session values. I replaced the misspelled
invocation.

All tests pass.
@jcmdln
Copy link
Author

jcmdln commented Sep 8, 2017

It appears that this was fixed in a PR. I will close this issue for the time being.

@jcmdln jcmdln closed this as completed Sep 8, 2017
@bwmarrin bwmarrin added this to the v0.18.0 milestone Dec 27, 2017
ErikMcClure pushed a commit to ErikMcClure/discordgo that referenced this issue Aug 4, 2020
…wmarrin#441)

Reference Issue: bwmarrin#440
This endpoint was declard twice in endpoints.go, and used in the
GuildInvites() method on Session values. I replaced the misspelled
invocation.

All tests pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants