Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel struct's JSON tag for Recipients is incorrect #443

Closed
darkgray1981 opened this issue Sep 17, 2017 · 1 comment
Closed

Channel struct's JSON tag for Recipients is incorrect #443

darkgray1981 opened this issue Sep 17, 2017 · 1 comment
Labels
fix Pull requests and issues related to bug fixes and structural inconsistencies
Milestone
v0.18.0

Comments

@darkgray1981
Copy link

The Channel struct has a JSON tag for the field Recipients that currently says "recipient", while the present API uses a field named "recipients", causing it to go unfilled by the unmarshaller.
See https://discordapp.com/developers/docs/resources/channel
@Hinara Hinara mentioned this issue Sep 20, 2017
Merged
@bwmarrin bwmarrin added the fix Pull requests and issues related to bug fixes and structural inconsistencies label Sep 21, 2017
@bwmarrin bwmarrin added this to the v0.18.0 milestone Sep 21, 2017
@bwmarrin
Copy link
Owner

Thanks for reporting the issue @darkgray1981 :)

bwmarrin added a commit that referenced this issue Sep 21, 2017
@bwmarrin
Merge pull request #444 from robbix1206/recipientBug
b7d7e03 
Fix #443 (recipients not recipient)
ErikMcClure pushed a commit to ErikMcClure/discordgo that referenced this issue Aug 4, 2020
@Hinara
Fix bwmarrin#443
fd2a52b
ErikMcClure pushed a commit to ErikMcClure/discordgo that referenced this issue Aug 4, 2020
@bwmarrin
Merge pull request bwmarrin#444 from robbix1206/recipientBug
d64d5ab 
Fix bwmarrin#443 (recipients not recipient)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fix Pull requests and issues related to bug fixes and structural inconsistencies
Projects
None yet
Milestone
v0.18.0
Development

No branches or pull requests
2 participants
@darkgray1981 @bwmarrin