Mapped Event Handlers #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| } | ||
| // Attempt to unmarshal our event. | ||
| // If there is an error we should handle the event itself. | ||
| if err = unmarshal(e.RawData, i); err != nil { |
There was a problem hiding this comment.
We unmarshal every event now.
It's a small change, and doesn't really change the runtime performance that I can see, but it is required to support the interface{} event type, which is really handy 👌
|
|
||
| // Exposed but should not be modified by User. | ||
| SessionID string // from websocket READY packet |
There was a problem hiding this comment.
I have removed SessionID as it is accessible from State.SessionID.
bwmarrin
added a commit
that referenced
this pull request
Feb 16, 2016
BREAKING CHANGE -- Mapped Event Handlers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change breaks the current API but makes it much more powerful.
Currently only one handler can be added for each event, with this change, any number of handlers can be added for the same event. Additionally it supports adding handlers for interface{} which will be triggered on every event.
The existing code:
is now:
Not bad for a net delta of -:100: lines.