Reconfigure Golangci Linter #1131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 11, 2022 10:48
Doesn't remove named return variables.
+ 3 wasted assignments
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These aren't technically breaking changes because no code logic is supposed to be changed. However, there may be errors in translation. These improvements are beneficial over the long term for a more maintainable (and contributor-friendly) code base.
Style
Removed over 200 occurrences of nakedreturns. A lot of unhandled errors (that are now handled). A lot of setting errors (inside the if statement) before returning (as opposed to simply returning the error).
I placed recommendations for disabled linters in
.golangci.yml. Edits by maintainers is allowed (as usual).