-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for setting guild region and verification level #132
Conversation
type GuildParams struct { | ||
Name string `json:"name"` | ||
Region string `json:"region"` | ||
VerificationLevel *int `json:"verification_level"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a VerificationLevel type then you can do:
type VerificationLevel uint
const (
VerificationLevelNone VerificationLevel = iota
VerificationLevelWhatever
VerificationLevelBlah
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do.
Looking at this, I'd almost like the struct to be named |
Maybe we could even get rid of GuildParams and just use Guild and only set the relevant attributes, much like ChannelInviteCreate does with Invite? |
I like that :) Add if they add more things we can change we don't need to change much. Also keeps the syntax shorter. |
Looking back on it, doing that would result in having to make Guild.VerificationLevel a |
BREAKING -- Add support for setting guild region and verification level
By the way, thanks a lot @nstafie I really do appreciate you helping out the project! |
:) I got some time to add consts for the values, I'll open a new PR! |
BREAKING -- Add support for setting guild region and verification level
No description provided.