fix: ThreadMember flags not serialized #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FedorLap2006
added
the
fix
FedorLap2006
reviewed
Mar 9, 2023
There was a problem hiding this comment.
Thanks for catching yet another oversight.
One thing to note though. I'm not entirely sure about the usage of musttag linter.
At least currently, It does not fullfil our needs. As an example:
- We tend to have a lot of nested structures, but after some local testing, it doesn't seem to catch any changes in them.
- Most of the structures are used in REST API functions, but the linter also doesn't seem catch any change in them.
In any case, it's going to be a good idea to separate the linter change into a different PR, to make things easier.
|
@FedorLap2006 It sounds like you are concerned about false negatives, which is the case with most linters. They safeguard against some but not all bugs. In this case the I removed the commit from this PR and opened #1345 |
|
Great! Since I'm still writing up the release notes for the v0.27.1, we can probably merge this as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Flagsfield was being incorrectly de/serialized as"Flags".ThreadMember spec: https://discord.com/developers/docs/resources/channel#thread-member-object
I caught this with the
musttaglinter, so I went ahead and added it to the linter config.